Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvements #186

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

peternewman
Copy link
Member

No description provided.

This was referenced Apr 14, 2018
@fxedel
Copy link
Member

fxedel commented Apr 16, 2018

Looks good! Some new version 2 features could be useful for OpenLightingProject/open-fixture-library#287.

@peternewman
Copy link
Member Author

Yes, that's part of the hope @fxedel . I need to sanity check this, as I did most of it over Christmas. Do you and @FloEdelmann want to take a look and see if there's anything obvious missing or you might want changed for v2 of the API?

We can always do a v3 and onwards if you find stuff later.

@FloEdelmann
Copy link
Member

FloEdelmann commented Apr 17, 2018

Is there a way to get all the information of one fixture (RDM model), identified by RDM manufacturer ID and RDM model ID? That'd be the most useful API for us, I think.

For me, it's not that obvious given only the Python source code. Maybe a simple Markdown API documentation (listing all possible endpoints, the data they take, and the format of the result they return) would be useful for others as well?

@peternewman
Copy link
Member Author

These two need cherry-picking to fix https://travis-ci.org/OpenLightingProject/rdm-app/jobs/377816384:
2739516
583051f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants